Update versions #121
Open
Update versions #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the illumiante/collections requirements to the supported PHP versions, see the following table:
Furthermore I think illuminate/collections doesn't exist before v8: see https://packagist.org/packages/illuminate/collections
So I am not even sure, what would be installed here.
Guzzle
^7.0.1is required as of laravel/illuminate 8.phpunit
^9.5is required as of laravel/illuminate 8.See https://github.com/laravel/laravel/blob/8.x/composer.json
PHPstan 2 can be used as of PHP 7.4.
See https://github.com/phpstan/phpstan/blob/2.0.x/composer.json
ext-json is always included as of PHP 8.0 and was therefor removed as a requirement.
See https://php.watch/versions/8.0/ext-json
Another note:
I needed to add
/* @phpstan-ignore class.extendsFinalByPhpDoc */to the GuzzleClient, because it extends the class client which has a phpdoc with@finalmeaning it should not be extended from. In my opinion should this be refactored in another PR.